Make isEqualToIgnoringGivenProperties accept subtype properties #572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes the properties parameter covariant on T, which allows passing properties of subtypes of T, eliminating the need to cast the test subject to its runtime type to access its properties.
Egorand
commented
Jul 14, 2025
| testObject() | ||
| ).isEqualToIgnoringGivenProperties( | ||
| BasicObject(str = "notRarity"), | ||
| BasicObject::str, |
There was a problem hiding this comment.
Prior to the change this would fail to compile, since at compilation time T == TestObject, so the method only allows passing properties of TestObject and not its subclasses.
🎉 Snyk checks have passed. No issues have been found so far.✅ code/snyk check is complete. No issues have been found. (View Details) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the properties parameter covariant on T, which allows passing properties of subtypes of T, eliminating the need to cast the test subject to its runtime type to access its properties.